Make the governed RAG evidence path executable end to end
Some checks failed
verify / verify (push) Has been cancelled
Some checks failed
verify / verify (push) Has been cancelled
Separate local parsing from model indexing, bind review decisions to immutable manifests, persist vectors behind active profiles, and expose retrieval, chat, evaluation, and document workflows through the React workbench. Constraint: Live Bailian authentication currently fails for all three configured capabilities Rejected: Direct upload-to-embedding flow | bypasses local review and manifest binding Confidence: high Scope-risk: broad Directive: Keep private-data deployment blocked until authentication, RBAC, and separate database roles land Tested: make verify; fresh and replay Docker document smoke; worker recovery smoke; frozen synthetic evaluation; migration 0003-0004 roundtrip Not-tested: Successful live Bailian calls, OCR, real multi-user authorization
This commit is contained in:
101
backend/app/workers/document_jobs.py
Normal file
101
backend/app/workers/document_jobs.py
Normal file
@@ -0,0 +1,101 @@
|
||||
"""PARSE_DOCUMENT business handler with storage verification and DB fencing."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import asyncio
|
||||
import uuid
|
||||
from collections.abc import Awaitable, Callable, Mapping
|
||||
from dataclasses import dataclass
|
||||
from typing import Protocol
|
||||
|
||||
from app.adapters.local_storage import LocalUploadStorage
|
||||
from app.core.config import Settings
|
||||
from app.persistence.document_workflows import (
|
||||
DocumentWorkflowRepository,
|
||||
PostgresDocumentWorkflowRepository,
|
||||
)
|
||||
from app.persistence.job_queue import BackgroundJob
|
||||
from app.services.document_ingestion import (
|
||||
ChunkingConfig,
|
||||
CloudTextPolicy,
|
||||
DocumentIngestionError,
|
||||
ingest_document,
|
||||
)
|
||||
|
||||
type DocumentJobHandler = Callable[[BackgroundJob], Awaitable[None]]
|
||||
|
||||
|
||||
class VerifiedUploadStorage(Protocol):
|
||||
async def read_verified(
|
||||
self,
|
||||
*,
|
||||
storage_key: uuid.UUID,
|
||||
expected_size: int,
|
||||
expected_sha256: str,
|
||||
) -> bytes: ...
|
||||
|
||||
|
||||
@dataclass(frozen=True, slots=True)
|
||||
class ParseDocumentHandler:
|
||||
repository: DocumentWorkflowRepository
|
||||
storage: VerifiedUploadStorage
|
||||
max_upload_bytes: int
|
||||
chunking: ChunkingConfig
|
||||
cloud_policy: CloudTextPolicy
|
||||
embedding_model: str
|
||||
embedding_dimension: int
|
||||
|
||||
async def __call__(self, job: BackgroundJob) -> None:
|
||||
source = await asyncio.to_thread(self.repository.load_source, job)
|
||||
content = await self.storage.read_verified(
|
||||
storage_key=source.storage_key,
|
||||
expected_size=source.byte_size,
|
||||
expected_sha256=source.raw_sha256,
|
||||
)
|
||||
try:
|
||||
artifact = await asyncio.to_thread(
|
||||
ingest_document,
|
||||
filename=source.filename,
|
||||
declared_mime_type=source.mime_type,
|
||||
content=content,
|
||||
max_upload_bytes=self.max_upload_bytes,
|
||||
chunking=self.chunking,
|
||||
cloud_policy=self.cloud_policy,
|
||||
)
|
||||
except DocumentIngestionError as exc:
|
||||
await asyncio.to_thread(
|
||||
self.repository.record_terminal_parse_failure,
|
||||
lease=job.lease,
|
||||
source=source,
|
||||
error_code=exc.code.value,
|
||||
)
|
||||
return
|
||||
await asyncio.to_thread(
|
||||
self.repository.persist_artifact,
|
||||
lease=job.lease,
|
||||
source=source,
|
||||
artifact=artifact,
|
||||
cloud_policy=self.cloud_policy,
|
||||
embedding_model=self.embedding_model,
|
||||
embedding_dimension=self.embedding_dimension,
|
||||
)
|
||||
|
||||
|
||||
def build_document_handlers(settings: Settings) -> Mapping[str, DocumentJobHandler]:
|
||||
"""Build the handler mapping consumed by the generic worker runtime."""
|
||||
|
||||
maximum_bytes = settings.max_upload_mb * 1024 * 1024
|
||||
handler = ParseDocumentHandler(
|
||||
repository=PostgresDocumentWorkflowRepository(settings),
|
||||
storage=LocalUploadStorage(settings.upload_root, max_bytes=maximum_bytes),
|
||||
max_upload_bytes=maximum_bytes,
|
||||
chunking=ChunkingConfig(
|
||||
target_tokens=settings.chunk_target_tokens,
|
||||
max_tokens=settings.chunk_max_tokens,
|
||||
overlap_tokens=settings.chunk_overlap_tokens,
|
||||
),
|
||||
cloud_policy=CloudTextPolicy(),
|
||||
embedding_model=settings.embedding_model,
|
||||
embedding_dimension=settings.embedding_dimension,
|
||||
)
|
||||
return {"PARSE_DOCUMENT": handler}
|
||||
89
backend/app/workers/indexing_jobs.py
Normal file
89
backend/app/workers/indexing_jobs.py
Normal file
@@ -0,0 +1,89 @@
|
||||
"""Worker handler wiring for governed document embedding jobs."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import uuid
|
||||
from collections.abc import Mapping, Sequence
|
||||
|
||||
from app.adapters.fake import FakeEmbeddingProvider
|
||||
from app.adapters.model_gateway import ModelGatewayAdapter
|
||||
from app.core.config import Settings
|
||||
from app.persistence.indexing import PostgresIndexingRepository
|
||||
from app.persistence.job_queue import BackgroundJob
|
||||
from app.ports.model_providers import EmbeddingResult
|
||||
from app.services.indexing import DocumentIndexingService
|
||||
from app.worker import JobHandler
|
||||
|
||||
|
||||
class InvalidIndexingJobError(RuntimeError):
|
||||
"""A safe job-envelope failure that never includes payload content."""
|
||||
|
||||
def __init__(self) -> None:
|
||||
super().__init__("EMBED_DOCUMENT job envelope is invalid")
|
||||
|
||||
|
||||
class _WorkerGatewayEmbeddingProvider:
|
||||
"""Open the internal gateway only for real provider batches.
|
||||
|
||||
Synthetic profiles are routed to ``FakeEmbeddingProvider`` by the service,
|
||||
so they never read a gateway token or create model-network traffic.
|
||||
"""
|
||||
|
||||
def __init__(self, settings: Settings) -> None:
|
||||
if settings.model_gateway_caller != "worker":
|
||||
raise ValueError("indexing handlers require MODEL_GATEWAY_CALLER=worker")
|
||||
self._settings = settings
|
||||
|
||||
async def embed_documents(self, texts: Sequence[str]) -> EmbeddingResult:
|
||||
async with ModelGatewayAdapter.from_settings(self._settings) as gateway:
|
||||
return await gateway.embed_documents(texts)
|
||||
|
||||
async def embed_query(self, text: str) -> EmbeddingResult:
|
||||
async with ModelGatewayAdapter.from_settings(self._settings) as gateway:
|
||||
return await gateway.embed_query(text)
|
||||
|
||||
|
||||
def build_embed_document_handler(service: DocumentIndexingService) -> JobHandler:
|
||||
"""Build a testable handler around one configured indexing service."""
|
||||
|
||||
async def handle(job: BackgroundJob) -> None:
|
||||
document_version_id = _document_version_id(job)
|
||||
await service.index_document_version(
|
||||
lease=job.lease,
|
||||
document_version_id=document_version_id,
|
||||
trace_id=job.id,
|
||||
)
|
||||
|
||||
return handle
|
||||
|
||||
|
||||
def build_indexing_handlers(settings: Settings) -> Mapping[str, JobHandler]:
|
||||
"""Return production handler registration without loading cloud credentials eagerly."""
|
||||
|
||||
if settings.model_gateway_caller != "worker":
|
||||
raise ValueError("indexing handlers require MODEL_GATEWAY_CALLER=worker")
|
||||
service = DocumentIndexingService(
|
||||
repository=PostgresIndexingRepository(settings),
|
||||
embedding_provider=_WorkerGatewayEmbeddingProvider(settings),
|
||||
synthetic_embedding_provider=FakeEmbeddingProvider(settings.embedding_dimension),
|
||||
)
|
||||
return {"EMBED_DOCUMENT": build_embed_document_handler(service)}
|
||||
|
||||
|
||||
def _document_version_id(job: BackgroundJob) -> uuid.UUID:
|
||||
raw_version_id = job.payload.get("document_version_id")
|
||||
if (
|
||||
job.job_type != "EMBED_DOCUMENT"
|
||||
or job.required_capability != "embedding"
|
||||
or job.resource_type != "document_version"
|
||||
or job.lease.job_id != job.id
|
||||
or not isinstance(raw_version_id, str)
|
||||
):
|
||||
raise InvalidIndexingJobError
|
||||
try:
|
||||
document_version_id = uuid.UUID(raw_version_id)
|
||||
except (AttributeError, ValueError):
|
||||
raise InvalidIndexingJobError from None
|
||||
if str(document_version_id) != raw_version_id or document_version_id != job.resource_id:
|
||||
raise InvalidIndexingJobError
|
||||
return document_version_id
|
||||
Reference in New Issue
Block a user